Update dependencies to support python 3.13 #249
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates all first-order dependencies to newer versions which support newer versions of python. Fix formatting while here to use 4-space indents instead of hard tabs, per PEP8. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
This change removes 3.8 pins as that version of python is no longer supported by the upstream python project. Remove outdated OS X instructions while here and do some minor formatting tweaks with h1 and h2 sections. Remove the manually provided ToC while here: GitHub automatically generates the ToC for "free". Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
This was referenced Sep 5, 2025
ngie-eign
added a commit
to ngie-eign/docker-grab-site
that referenced
this pull request
Sep 5, 2025
... until the update is pushed upstream in ArchiveTeam/grab-site#249. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
... is bumped as part of ArchiveTeam/ludios_wpull#36 . Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
ngie-eign
force-pushed
the
py313-support
branch
from
8b7a66a to
e81eed8
Compare
stdedos
reviewed
Nov 14, 2025
| "google-re2>=1.0.6", | ||
| "websockets>=6.0", | ||
| "click>=8.0.0", | ||
| "wpull @ https://github.com/ngie-eign/ludios_wpull/archive/py313-support.zip", |
There was a problem hiding this comment.
Would you consider switching that to e.g.
Suggested change
| "wpull @ https://github.com/ngie-eign/ludios_wpull/archive/py313-support.zip", | |
| "wpull~=5.0.4", |
?
The MR ArchiveTeam/ludios_wpull#36 is merged + released now.
And it seems that this
"wpull @ https://github.com/ngie-eign/ludios_wpull/archive/py313-support.zip",doesn't work anymore
$ uvx --python=3.8 --no-binary-package lxml git+https://github.com/ngie-eign/grab-site@py313-support
Updated https://github.com/ngie-eign/grab-site (e81eed8c37616492466848ab5ed68104c7339693)
× Failed to download and build `wpull @ https://github.com/ngie-eign/ludios_wpull/archive/py313-support.zip`
├─▶ Failed to fetch: `https://github.com/ngie-eign/ludios_wpull/archive/py313-support.zip`
╰─▶ HTTP status client error (404 Not Found) for url (https://codeload.github.com/ngie-eign/ludios_wpull/zip/py313-support)There was a problem hiding this comment.
Actually, wpull~=5.0.4 does not exist in PyPI (https://pypi.org/project/wpull/ only a very old version of it).
I guess the correct solution would be
git+https://github.com/ArchiveTeam/ludios_wpull@5.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates all pins to work with software that supports python 3.13, in an effort to add support for new supported versions of python.
This change doesn't go in-depth to burn any bridges associated with unsupported versions of python, e.g., pre-3.9. This should be handled in a separate change.
The proposed change in the PR is potentially rough around the edges and followup commits may need to be performed to make the code function fully with python 3.8+, however the likelihood of things functioning out of the box with 3.9/3.10 is high.
Depends on: ArchiveTeam/ludios_wpull#36.
Closes: #245.