Refactor version retrieval in PaperEnhancements#330
Open
zrll12 wants to merge 1 commit intoArcanePlugins:dev/v2from
Open
Refactor version retrieval in PaperEnhancements#330zrll12 wants to merge 1 commit intoArcanePlugins:dev/v2from
zrll12 wants to merge 1 commit intoArcanePlugins:dev/v2from
Conversation
fix: java.lang.NumberFormatException: For input string: "craftbukkit" at java.base/java.lang.NumberFormatException.forInputString(Unknown Source) ~[?:?] at java.base/java.lang.Integer.parseInt(Unknown Source) ~[?:?] at java.base/java.lang.Integer.parseInt(Unknown Source) ~[?:?] at java.base/java.util.stream.ReferencePipeline$4$1.accept(Unknown Source) ~[?:?] at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Unknown Source) ~[?:?] at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:?] at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) ~[?:?] at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:?] at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source) ~[?:?] at java.base/java.util.stream.IntPipeline.toArray(Unknown Source) ~[?:?] at treasury-bukkit-2.0.1-7417830-RELEASE.jar/me.lokka30.treasury.plugin.bukkit.vendor.paper.PaperEnhancements.enhance(PaperEnhancements.java:19) ~[treasury-bukkit-2.0.1-7417830-RELEASE.jar:?] at treasury-bukkit-2.0.1-7417830-RELEASE.jar/me.lokka30.treasury.plugin.bukkit.TreasuryBukkit.onEnable(TreasuryBukkit.java:65) ~[treasury-bukkit-2.0.1-7417830-RELEASE.jar:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.jar:1.21-130-b1b5d4c] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.jar:1.21-130-b1b5d4c] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:640) ~[paper-1.21.jar:1.21-130-b1b5d4c] at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:589) ~[paper-1.21.jar:1.21-130-b1b5d4c] at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:293) ~[paper-1.21.jar:1.21-130-b1b5d4c] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1215) ~[paper-1.21.jar:1.21-130-b1b5d4c] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330) ~[paper-1.21.jar:1.21-130-b1b5d4c] at java.base/java.lang.Thread.run(Unknown Source) ~[?:?]
Jikoo
approved these changes
Jan 1, 2026
Collaborator
Jikoo
left a comment
There was a problem hiding this comment.
Sorry about the slow reply. As a stopgap, looks good.
We should probably refactor this entirely to use a more robust system - it will yield inaccurate results when Mojang swaps to year-based versioning in 2026 because it assumed Minecraft would never hit 2.0.
I do have Version (and BukkitVersions) in PlanarWrappers already if we want to consider that for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
java.lang.NumberFormatException: For input string: "craftbukkit"
at java.base/java.lang.NumberFormatException.forInputString(Unknown Source) ~[?:?]
at java.base/java.lang.Integer.parseInt(Unknown Source) ~[?:?]
at java.base/java.lang.Integer.parseInt(Unknown Source) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$4$1.accept(Unknown Source) ~[?:?]
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Unknown Source) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source) ~[?:?]
at java.base/java.util.stream.IntPipeline.toArray(Unknown Source) ~[?:?]
at treasury-bukkit-2.0.1-7417830-RELEASE.jar/me.lokka30.treasury.plugin.bukkit.vendor.paper.PaperEnhancements.enhance(PaperEnhancements.java:19) ~[treasury-bukkit-2.0.1-7417830-RELEASE.jar:?]
at treasury-bukkit-2.0.1-7417830-RELEASE.jar/me.lokka30.treasury.plugin.bukkit.TreasuryBukkit.onEnable(TreasuryBukkit.java:65) ~[treasury-bukkit-2.0.1-7417830-RELEASE.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:640) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:589) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:293) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1215) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330) ~[paper-1.21.jar:1.21-130-b1b5d4c]
at java.base/java.lang.Thread.run(Unknown Source) ~[?:?]