Skip to content

Conversation

@keithchev
Copy link
Member

@keithchev keithchev commented Jul 2, 2025

This PR adds the prod and test PyPI servers to pyproject.toml. Their omission was essentially a bug introduced during the migration to poetry and pyproject.toml in #57.

Drive-bys:

  • update the .gitignore to a more conventional version.
  • update author list in pyproject.toml (I replaced a generic Arcadia email with my own contact info for maintainability).

@keithchev keithchev requested a review from lanery July 2, 2025 20:13
Copy link

@lanery lanery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @keithchev all looks fine to me! Then again, I don't really know how the pyproject.toml has to be configured to work with the PyPI servers... best I could do is confirm that it matches the blocks in arcadia-pycolor as well as the poetry docs. Might want to ask for another set of eyes if you have any doubts.

@keithchev
Copy link
Member Author

Hey @keithchev all looks fine to me! Then again, I don't really know how the pyproject.toml has to be configured to work with the PyPI servers...

Thanks! fwiw, I "tested" this in prod when I released a new version last week (v0.6.6), so it should be good 😎

@keithchev keithchev merged commit 775b0bb into master Jul 7, 2025
2 checks passed
@keithchev keithchev deleted the kcc/publishing-changes branch July 7, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants