Merged
Conversation
…sesql-module Use parsesql for table name detection
Araq
reviewed
Oct 15, 2025
Co-authored-by: Andreas Rumpf <araq4k@proton.me>
Araq
reviewed
Oct 15, 2025
| retExpr: NimNode | ||
|
|
||
| # Execute a non-row SQL statement strictly (errors on failure) | ||
| template execNoRowsStrict*(sqlStmt: string) = |
Contributor
Author
There was a problem hiding this comment.
Ah, so that is something GPT5 added. I'd committed the first changes already when I saw these. It looked odd but I figured they already existed.
I'm not sure if these are any better to use than a plain db.exec. Is doing the prepare statement and query steps beneficial? Seems like a bit of AI slop to drop.
Araq
reviewed
Oct 15, 2025
Co-authored-by: Andreas Rumpf <araq4k@proton.me>
Owner
|
Good enough for me. Further improvements can be done as new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes a different, simpler approach than the other PR. Transactions are just simple try excepts that handle setting up transactions instead of trying make
querysupport multi-statements and then including transactions in the DSL.Outer try excepts: