Merged
Conversation
…ojects/nims/ormin/tests/tcommon.nim
elcritch
commented
Sep 20, 2025
| @@ -37,6 +39,79 @@ var | |||
| Function(name: "replace", arity: 3, typ: dbVarchar) | |||
Contributor
Author
There was a problem hiding this comment.
Be nice to upgrade these at some point to also support type checking the args. But alas, not today.
elcritch
commented
Sep 20, 2025
| macro importSql*(n: typed): untyped = | ||
| ## Registers a Nim proc as callable SQL function within the query DSL. | ||
| if n.kind notin {nnkProcDef, nnkFuncDef}: | ||
| macros.error("{.importSql.} can only be applied to proc or func definitions", n) |
Contributor
Author
There was a problem hiding this comment.
I used GPT5-Codex-High for this. Seems to have done a good job. It checked for conditions I wouldn't have thought to check. I had to cleanup a little bit in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic support for custom sql functions using
importSqlpragma: