Skip to content

Changed the styling#18

Open
ishika-sen wants to merge 3 commits intoAqsa4066:mainfrom
ishika-sen:home/page
Open

Changed the styling#18
ishika-sen wants to merge 3 commits intoAqsa4066:mainfrom
ishika-sen:home/page

Conversation

@ishika-sen
Copy link
Contributor

No description provided.

Copy link

@Rahma5983 Rahma5983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! The CSS is clean, responsive, and well-structured. Just one tiny thing — the .third {} class is empty and can be removed, but it’s not blocking. Approved for merge

@Aqsa4066
Copy link
Owner

The styling is good. But can you add the background image and adjust its opacity accordingly?

@ishika-sen
Copy link
Contributor Author

ishika-sen commented Jul 29, 2025

But can you add the background image and adjust its opacity accordingly?

Yes, what type of background do u want?

@Aqsa4066
Copy link
Owner

You can download the same image as it is in the original Netflix website and then add it. Also, what about the Netflix logo?

@ishika-sen ishika-sen marked this pull request as draft July 29, 2025 18:36
@ishika-sen
Copy link
Contributor Author

You can download the same image as it is in the original Netflix website and then add it. Also, what about the Netflix logo?

Okay

@ishika-sen ishika-sen closed this Jul 29, 2025
@ishika-sen ishika-sen reopened this Jul 29, 2025
@ishika-sen ishika-sen marked this pull request as ready for review July 29, 2025 18:52
@Aqsa4066
Copy link
Owner

bg

@Aqsa4066
Copy link
Owner

Aqsa4066 commented Jul 29, 2025

I would love if you add this image in background.

@ishika-sen
Copy link
Contributor Author

I would love if you add this image in background.

can you please review it now

@Aqsa4066
Copy link
Owner

Thanks for your PR! To keep the codebase clean and easy to review, could you please split this into separate PRs — one for each feature? I’d like to merge the third commit.

@ishika-sen
Copy link
Contributor Author

Thanks for your PR! To keep the codebase clean and easy to review, could you please split this into separate PRs — one for each feature? I’d like to merge the third commit.

Hey I did can you please check and review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants