Enable 8 previously disabled tests #491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
CI-Lin-CUDA-Tests1 files ± 0 1 errors 0 suites - 1 0s ⏱️ - 11m 58s For more details on these parsing errors, see this check. Results for commit e053b27. ± Comparison against base commit 669df2a. ♻️ This comment has been updated with latest results. |
Enable tests that were unnecessarily disabled: module_tests.cpp (4 tests): - stop: Tests module stop functionality - stop_bug: Tests stop edge case - pipeline_relay: Tests pipeline relay mode - feedbackmodule: Tests feedback module functionality cv_memory_leaks_tests.cpp (2 tests): - cv_mat_memory_leak_2: OpenCV memory test - cv_memory_leak_all: Comprehensive OpenCV memory test filereadermodule_tests.cpp (4 tests): - pipeline_relay: Tests file reader pipeline relay - configpipeline: Tests pipeline configuration - pipeline_exit: Tests pipeline exit handling - pipeline_readone_exit: Tests single-read pipeline exit All tests verified passing on Linux x64 builder with RTX 4060. Tests that require hardware (CSI camera, webcam, RTSP server) or have genuine bugs remain disabled with documented reasons. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cv_mat_memory_leak_2 and cv_memory_leak_all are not useful tests: - On Linux: cv::imshow is skipped via #ifndef LINUX, so the loop does nothing - On Windows: cv::imshow fails because CI OpenCV lacks GUI support These tests don't validate anything meaningful - just legacy memory leak checks that aren't properly portable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
kumaakh
force-pushed
the
improve-disabled-tests
branch
from
b73707f to
e053b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables 8 tests that were unnecessarily disabled:
module_tests.cpp (4 tests):
stop- Tests module stop functionalitystop_bug- Tests stop edge casepipeline_relay- Tests pipeline relay modefeedbackmodule- Tests feedback module functionalityfilereadermodule_tests.cpp (4 tests):
pipeline_relay- Tests file reader pipeline relayconfigpipeline- Tests pipeline configurationpipeline_exit- Tests pipeline exit handlingpipeline_readone_exit- Tests single-read pipeline exitAll 8 tests were verified passing on Linux x64 and ARM64 before enabling.
Test plan
🤖 Generated with Claude Code