Remove Baresip and libre, revert changes in H264Decoder and NvTransform specific to NVR and fix a memory leak in nvcodec decoder #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mraduldubey
requested changes
Oct 3, 2024
| ${OpenCV_INCLUDE_DIRS} | ||
| ${Boost_INCLUDE_DIRS} | ||
| ${LIBMP4_INC_DIR} | ||
| ${BARESIP_INC_DIR} |
Collaborator
There was a problem hiding this comment.
Lets keep an option open to build with baresip if required
| //mShouldTriggerSOS = true; | ||
| auto frame = frame_sp(new EmptyFrame()); | ||
| mDetail->compute(frame->data(), frame->size(), frame->timestamp); | ||
| LOG_ERROR << "processes sos " ; |
Collaborator
There was a problem hiding this comment.
why is thie log error.
| { | ||
| Module& m = *(modules[0]->controlModule); | ||
| m.myThread = boost::thread(ref(m)); | ||
| Utils::setModuleThreadName(m.myThread, m.getId()); |
Collaborator
There was a problem hiding this comment.
a merge with md/controlmodulepipelineFixes is required
Collaborator
There was a problem hiding this comment.
not reviewing this file
- Introduced a new documentation file summarizing changes made to the H264 decoder. - Removed dependencies on libre and baresip libraries. - Enhanced resource management with CUDA context cleanup in the decoder. - Improved output bitstream handling and added missing return values in utility functions. - Enabled EOS processing and metadata reset in relevant modules. - Updated thread management for control modules. These changes focus on cleaning up dependencies, improving resource management, and enhancing overall code quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[Issue]
Description
Summary
Remove Baresip and Libre dependencies
Revert changes in H264Decoder and NvTransform (specific to NVR)
H264DecoderandNvTransformcomponents.Fix memory leak in nvcodec decoder
nvcodecdecoder.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Bug fix)
Screenshots (if applicable)
Checklist