Skip to content

Conversation

@radbasa
Copy link
Collaborator

@radbasa radbasa commented Jul 10, 2024

Closes #111

Description

  • allows multiple separate box::use() calls for both packages and modules
  • new function to manage multiple box::use() calls to fit in current architecture/algorithm
  • box PR may be a better solution in the future.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (861ec8c) to head (e4cdbb5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   98.38%   98.41%   +0.03%     
==========================================
  Files          21       21              
  Lines         804      821      +17     
==========================================
+ Hits          791      808      +17     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radbasa radbasa marked this pull request as ready for review July 10, 2024 11:25
@radbasa radbasa requested a review from jakubnowicki July 10, 2024 11:25
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radbasa radbasa merged commit 845e91e into main Jul 11, 2024
@radbasa radbasa deleted the allow-multiple-box-use-calls branch July 11, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LINT_BUG]: Multiple box::use() calls cause lint to fail

3 participants