Conversation
…date OpenAPI schema
….json and package-lock.json
UN-2283: get finance type
UN-2278-post-attachment
UN-2281: get finance suppliers
Tests difference:New Tests |
…e new_supplier_name
…andling in other costs patch
…n other costs patch
Patch other costs
…ne deletion and addition
…ire at least one attachment
…with enhanced validation
…with improved validation and error handling
Other costs accept array
Add presign url get other costs
…ge.json and package-lock.json
… removed after S3 deletion
feat: update attachment deletion logic to ensure database records are…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new API endpoints and tests for managing campaign finance attachments and "other costs", along with minor dependency and utility improvements. The main changes include implementing GET and DELETE endpoints for campaign finance other costs, adding a POST endpoint for uploading finance attachments, and providing comprehensive tests for these new features.
New API Endpoints and Core Features:
_get/index.ts) for/campaigns/{campaignId}/finance/otherCoststhat returns all "other costs" for a campaign, including their types, suppliers, and attachments with presigned S3 URLs._delete/index.ts) for/campaigns/{campaignId}/finance/otherCoststo delete a cost and its attachments from both the database and S3, with proper access and validation checks._post/index.ts) for/campaigns/{campaignId}/finance/attachmentsto upload finance-related attachments, with validation for file types and size.Testing Improvements:
Utility and Dependency Updates:
getPresignedUrlutility to accept a custom expiration time, defaulting to 20 minutes.@appquality/tryber-databasedependency to version^0.46.20inpackage.json.