This repository was archived by the owner on Mar 26, 2019. It is now read-only.
Add Authorization Feature to AspNetCoreHealth#16
Open
jvonruden wants to merge 3 commits intoAppMetrics:devfrom
Open
Add Authorization Feature to AspNetCoreHealth#16jvonruden wants to merge 3 commits intoAppMetrics:devfrom
jvonruden wants to merge 3 commits intoAppMetrics:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
AppMetrics/AppMetrics#366
Details on the issue fix or feature implementation
Add Authorization Feature to AspNetCoreHealth. Instead of implementing Authorization details in AspNetCoreHealth use dependency injection with IHealthAuthorizationFilter interface to allow the calling application to implement their own Authorization Mechanism. The HttpContext context is passed into the IHealthAuthorizationFilter Authorized method because the most likely scenario is the caller will want to check for an Authorization headers and secrets.
Confirm the following