Skip to content
This repository was archived by the owner on Mar 26, 2019. It is now read-only.

Add Authorization Feature to AspNetCoreHealth#16

Open
jvonruden wants to merge 3 commits intoAppMetrics:devfrom
jvonruden:dev
Open

Add Authorization Feature to AspNetCoreHealth#16
jvonruden wants to merge 3 commits intoAppMetrics:devfrom
jvonruden:dev

Conversation

@jvonruden
Copy link
Copy Markdown

The issue or feature being addressed

AppMetrics/AppMetrics#366

Details on the issue fix or feature implementation

Add Authorization Feature to AspNetCoreHealth. Instead of implementing Authorization details in AspNetCoreHealth use dependency injection with IHealthAuthorizationFilter interface to allow the calling application to implement their own Authorization Mechanism. The HttpContext context is passed into the IHealthAuthorizationFilter Authorized method because the most likely scenario is the caller will want to check for an Authorization headers and secrets.

Confirm the following

  • [X ] I have ensured that I have merged the latest changes from the dev branch
  • [X ] I have successfully run a local build
  • [X ] I have included unit tests for the issue/feature
  • I have included the github issue number in my commits

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant