Skip to content

Conversation

@redreceipt
Copy link
Member

Summary

  • include unassigned issues when fetching Customer Success queries
  • display unassigned issues along with Customer Success items for on-call support

Testing

  • python -m py_compile app.py linear.py
  • python -m compileall -q .

https://chatgpt.com/codex/tasks/task_e_687955c4e520832489a737c59e75d35a

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A concise description of the purpose of the PR, followed by summarized bullets of changes

  • Extend GraphQL queries to include unassigned issues (project = null) alongside "Customer Success"
  • Update Python grouping logic to treat unassigned issues as "No Project" in on-call support views

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
linear.py Added an or condition in filters for open, completed, and created issue queries to include null projects
app.py Modified team_slug grouping to include "No Project" key alongside "Customer Success"
Comments suppressed due to low confidence (2)

linear.py:50

  • The new behavior of including unassigned issues isn't covered by existing tests. Please add test cases for scenarios where project is null in get_open_issues, and similarly for get_completed_issues and get_created_issues.
def get_open_issues(priority, label):

app.py:203

  • This check assumes open_by_project uses the string "No Project" for unassigned issues. If the key is actually None, unassigned issues won't be included here. Either map None to "No Project" beforehand or include proj is None in this condition.
            if proj in ["Customer Success", "No Project"]

linear.py Outdated
Comment on lines 58 to 63
labels: { name: { eq: $label } }
project: { name: { eq: "Customer Success" } }
priority: { lte: $priority }
state: { name: { nin: ["Done", "Canceled", "Duplicate"] } }
or: [
{ project: { name: { eq: "Customer Success" } } },
{ project: null }
Copy link

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or is added at the top level, which may cause unassigned or Customer Success issues to bypass other filters (labels, priority, state). Consider wrapping the existing filters and this or clause inside an explicit and block to ensure all conditions are combined correctly.

Copilot uses AI. Check for mistakes.
@redreceipt redreceipt temporarily deployed to bug-board-codex-pull-un-veeg0q July 18, 2025 21:03 Inactive
@redreceipt redreceipt merged commit 2421476 into main Jul 18, 2025
2 checks passed
@redreceipt redreceipt deleted the codex/pull-unassigned-linear-issues branch July 18, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants