Refactor app.py: improve type annotations and extract helper functions

[Copilot]

Apply five code quality improvements addressing type safety, maintainability, and code organization issues identified in review.

Changes

• TypeVar naming: Renamed T to ResultType for clarity in future result handling context

• IndexFutures TypedDict: Replaced 11-element tuple return with typed dictionary for _submit_index_futures:

  # Before: tuple unpacking of 11 positional Future objects
  return (created_priority_future, open_priority_future, ...)
  
  # After: typed dictionary with descriptive keys
  return {
      "created_priority": created_priority_future,
      "open_priority": open_priority_future,
      ...
  }

  Added proper type parameters (Future[list], Future[dict]) to all Future annotations

• Cache configuration: Extracted INDEX_CONTEXT_CACHE_MAXSIZE = 16 constant with documentation for production tuning

• Helper function extraction: Moved priority bug processing logic from _build_index_context to dedicated _get_priority_bugs_from_futures function (~30 lines)

• Deduplication: Promoted nested format_display_name to module level, eliminating local redefinition

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"[nitpick] The TypeVar 'T' should have a more descriptive name like 'ResultType' or 'FutureResultType' to clarify its purpose in the context of future result handling.","fixFiles":[{"filePath":"app.py","diff":"diff --git a/app.py b/app.py\n--- a/app.py\n+++ b/app.py\n@@ -150,14 +150,14 @@\n         return date_str\n \n \n-T = TypeVar('T')\n+ResultType = TypeVar('ResultType')\n \n \n def get_future_result_with_timeout(\n-    future: Future[T],\n-    default_value: T,\n+    future: Future[ResultType],\n+    default_value: ResultType,\n     timeout: int = INDEX_FUTURE_TIMEOUT\n-) -> T:\n+) -> ResultType:\n     \"\"\"\n     Get result from a future with a timeout, returning a default value on timeout.\n \n"}]},{"message":"The function returns a tuple with 11 Future objects, which is difficult to maintain and error-prone. Consider using a TypedDict or dataclass to group related futures (e.g., 'completed_futures', 'open_futures', 'github_futures') for better readability and maintainability.","fixFiles":[{"filePath":"app.py","diff":"diff --git a/app.py b/app.py\n--- a/app.py\n+++ b/app.py\n@@ -153,6 +153,21 @@\n T = TypeVar('T')\n \n \n+class IndexFutures(TypedDict):\n+    \"\"\"Named collection of futures used for building the index view.\"\"\"\n+    completed_issues: Future\n+    completed_issues_summary: Future\n+    created_issues: Future\n+    open_issues: Future\n+    open_issues_by_assignee: Future\n+    open_issues_by_platform: Future\n+    open_issues_by_project: Future\n+    time_data: Future\n+    projects: Future\n+    merged_prs_by_author: Future\n+    merged_prs_by_reviewer: Future\n+\n+\n def get_future_result_with_timeout(\n     future: Future[T],\n     default_value: T,\n@@ -178,19 +193,7 @@\n def _submit_index_futures(\n     executor: ThreadPoolExecutor,\n     days: int,\n-) -> tuple[\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-    Future,\n-]:\n+) -> IndexFutures:\n     \"\"\"\n     Submit all futures required to build the index context.\n \n"}]},{"message":"[nitpick] The cache maxsize of 16 may be too small for a production application. Consider increasing this value or making it configurable based on expected usage patterns to improve cache hit rates.","fixFiles":[{"filePath":"app.py","diff":"diff --git a/app.py b/app.py\n--- a/app.py\n+++ b/app.py\n@@ -37,7 +37,11 @@\n \n app = Flask(__name__)\n \n+# Maximum number of distinct _build_index_context results to cache.\n+# This can be increased or made configurable based on production usage patterns.\n+INDEX_CONTEXT_CACHE_MAXSIZE = 16\n \n+\n def record_breakdown(\n     store_points: dict[str, dict[str, int]],\n     store_counts: dict[str, dict[str, int]],\n@@ -238,7 +241,7 @@\n     )\n \n \n-@lru_cache(maxsize=16)\n+@lru_cache(maxsize=INDEX_CONTEXT_CACHE_MAXSIZE)\n def _build_index_context(days: int, _cache_epoch: int) -> dict:\n     with ThreadPoolExecutor(max_workers=INDEX_THREADPOOL_MAX_WORKERS) as executor:\n         (\n"}]},{"message":"This function is extremely long (357 lines) and handles multiple responsibilities including data fetching, processing, scoring, and leaderboard generation. Consider breaking it into smaller, focused functions for better maintainability and testability.","fixFiles":[{"filePath":"app.py","diff":"diff --git a/app.py b/app.py\n--- a/app.py\n+++ b/app.py\n@@ -238,6 +238,36 @@\n     )\n \n \n+def _get_priority_bugs_from_futures(\n+    created_priority_future: Future,\n+    open_priority_future: Future,\n+    completed_priority_future: Future,\n+) -> tuple[list, list, list]:\n+    \"\"\"\n+    Retrieve priority bug data from futures and filter completed issues.\n+\n+    Only non-project issues are included in the completed list.\n+    \"\"\"\n+    created_priority_bugs = get_future_result_with_timeout(\n+        created_priority_future, []\n+    )\n+    open_priority_bugs = get_future_result_with_timeout(\n+        open_priority_future, []\n+    )\n+\n+    # Only include non-project issues in the index summary\n+    completed_priority_result = get_future_result_with_timeout(\n+        completed_priority_future, []\n+    )\n+    completed_priority_bugs = [\n+        issue\n+        for issue in completed_priority_result\n+        if not issue.get(\"project\")\n+    ]\n+\n+    return created_priority_bugs, open_priority_bugs, completed_priority_bugs\n+\n+\n @lru_cache(maxsize=16)\n def _build_index_context(days: int, _cache_epoch: int) -> dict:\n     with ThreadPoolExecutor(max_workers=INDEX_THREADPOOL_MAX_WORKERS) as executor:\n@@ -255,18 +285,15 @@\n             authored_prs_future,\n         ) = _submit_index_futures(executor, days)\n \n-    created_priority_bugs = get_future_result_with_timeout(created_priority_future, [])\n-    open_priority_b...

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.