Skip to content

fix minor issues with lm_decomposition.py pipeline #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mivanit wants to merge 2 commits into
base: feature/unify
Choose a base branch
from
Open

fix minor issues with lm_decomposition.py pipeline #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2715a7e
update torch dep for using set_submodule
mivanit Jun 17, 2025
e4434ee
fix loading pretrained models from hf
mivanit Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description = "Sparse Parameter Decomposition"
requires-python = ">=3.11"
readme = "README.md"
dependencies = [
"torch<2.6.0",
"torch>2.4.1,<2.6.0",
"torchvision",
"pydantic",
"wandb",
Expand Down
7 changes: 6 additions & 1 deletion spd/experiments/lm/lm_decomposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ def plot_lm_results(


def main(
config_path_or_obj: Path | str | Config, sweep_config_path: Path | str | None = None
config_path_or_obj: Path | str | Config,
sweep_config_path: Path | str | None = None,
# due to pytorch vuln https://nvd.nist.gov/vuln/detail/CVE-2025-32434
# hf `transformers` library doesn't allow loading with weights_only=True
weights_only: bool = True,
) -> None:
config = load_config(config_path_or_obj, config_model=Config)

Expand All @@ -72,6 +76,7 @@ def main(
path_to_class=config.pretrained_model_class,
model_path=None,
model_name_hf=config.pretrained_model_name_hf,
weights_only=weights_only,
)

# --- Setup Run Name and Output Dir --- #
Expand Down