Merge beta to main which brings in fixes for ld2412 and ld2450 stuck targets #39

bharvey88 · 2025-12-02T19:54:06Z

Version:

What does this implement/fix?

Types of changes

Bugfix (fixed change that fixes an issue)
New feature (thanks!)
Breaking change (repair/feature that breaks existing functionality)
Dependency Update - Does not publish
Other - Does not publish
Website of github readme file update - Does not publish
Github workflows - Does not publish

Checklist / Checklijst:

The code change has been tested and works locally
The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

Added/updated documentation for the web page

Summary by CodeRabbit

Chores
- Updated minimum ESPHome version requirement to 2025.11.0
- Updated application version to 25.11.20.1
Updates
- Improved LD2450 presence detection sensor naming for better clarity and device identification
- Enhanced system connectivity status tracking with explicit identifier
- Refined sensor performance configuration

_{✏️ Tip: You can customize this high-level summary in your review settings.}

… id names discord user Mistar Muffin pointed out the names were not specific on ld2450 presence target entities. I edited the names to match the same as LD2412 names and edited each entity ID for both ld2412/ld2450 to more accurately reflect the name of the entities. https://discord.com/channels/1126966963206361199/1354841614178062417/1418203837310963712

…me-fixes update ld2412 and ld2450 target entities with better names and better id names

Removed throttle filters from various target counts and coordinates for LD2450. Matches bdraco's suggested fix here: bdraco#1 likely needs to be done on LD2412 entities as well as an esphome issue raised - will test and open issue with esphome first.

fix copy paste mistake changing the ld2450 radar entitiy id and name

Remove throttle filters from LD2450 targets

Removed throttle filters from various LD2412 metrics.

…xes are not present before this version

Remove throttle filters from LD2412 metrics

coderabbitai · 2025-12-02T19:54:15Z

Walkthrough

ESPHome configuration files updated with version 25.11.20.1, LD2450 binary sensor identifiers and names standardized with explicit ID prefixes, throttle filters removed for performance optimization, and minimum ESPHome version requirement increased to 2025.11.0 across device variants.

Changes

Cohort / File(s)	Summary
LD2450 Binary Sensor Refactoring `Integrations/ESPHome/Core.yaml`	Renamed LD2450 platform binary sensors with standardized ID prefixes: `has_target_bs` → `ld2450_presence`, `has_moving_target_bs` → `ld2450_moving_target`, `has_still_target_bs` → `ld2450_still_target`. Updated corresponding display names to include "LD2450" prefix for clarity.
Configuration Optimization & Updates `Integrations/ESPHome/Core.yaml`	Added explicit ID (`ink_ha_connected`) to Online binary sensor. Removed multiple throttle filter blocks (500ms) from LD2450 presence, target, and count sensor definitions. Updated core version to 25.11.20.1. Adjusted end-of-file formatting for rgb_light entries.
Minimum Version Updates `Integrations/ESPHome/R_PRO-1_ETH.yaml`, `Integrations/ESPHome/R_PRO-1_W.yaml`	Updated `esphome.project.min_version` from 2024.6.4 to 2025.11.0 across both device variant configurations.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Straightforward configuration updates with predictable patterns (version numbers, ID renames, filter removals)
No complex logic or control flow changes
Verify consistency of ID naming conventions across LD2450 sensor renames
Confirm throttle filter removal doesn't impact intended sensor update frequencies

Poem

🐰 Sensors now speak with clearer names,
LD2450 presence stakes its claims,
Old throttles fade, new versions gleam,
From twenty-twenty-four's old dream.
Configuration paths align once more—
This rabbit hops to open doors! 🚪✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main changes: merging fixes for ld2412 and ld2450 stuck targets, which aligns with the binary sensor renaming and configuration updates in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch beta

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Integrations/ESPHome/Core.yaml (1)

1-884: PR description is empty; missing migration guide and test results.

The PR body uses the repository's default template with no additional context. To safely merge a breaking change, provide:

Detailed description of the fixes for LD2412 and LD2450 "stuck targets."

Test results confirming the fixes work as intended.

Migration guide for users affected by entity ID changes (see related comments above).

Changelog entry documenting the breaking changes and version requirements.

Rationale for throttle removal and performance implications.

Would you like help drafting a migration guide or changelog entry documenting these breaking changes?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df2659d and 7d2cdf8.

📒 Files selected for processing (3)

Integrations/ESPHome/Core.yaml (4 hunks)
Integrations/ESPHome/R_PRO-1_ETH.yaml (1 hunks)
Integrations/ESPHome/R_PRO-1_W.yaml (1 hunks)

🔇 Additional comments (5)

Integrations/ESPHome/R_PRO-1_ETH.yaml (1)

14-14: Version bump aligns with R_PRO-1_W.yaml; pending upstream validation.

This change mirrors the version bump in R_PRO-1_W.yaml. Once the ESPHome 2025.11.0 version is confirmed, both device configs will be consistent.

Integrations/ESPHome/Core.yaml (3)

569-569: Clarify scope and rationale for throttle filter removal.

The AI summary indicates that throttle filters have been removed from various sensor definitions (including LD2450 presence/target counts and LD2412 gate energies), but the provided code snippet only shows a blank line at line 569. The extent of throttle removals is not fully visible.

Questions:

How many throttle filters were removed? (all LD2450 and LD2412 sensors, or specific ones?)

What is the rationale? Is this to fix the "stuck targets" issue, or a separate performance optimization?

What are the performance/resource implications? (more frequent updates = higher CPU/memory usage)

Please clarify the throttle removal strategy and confirm it directly addresses the "stuck targets" issue mentioned in the PR title.

340-340: The id: ink_ha_connected field is for internal ESPHome component references, not Home Assistant entity references. Home Assistant automations and templates reference entities by their entity_id (e.g., binary_sensor.online), which is derived from the sensor's platform and name—not the ESPHome id. Adding or modifying an explicit ESPHome ID does not break existing HA automations or templates.

Likely an incorrect or invalid review comment.

2-2: Clarify internal firmware versioning — 25.11.20.1 is not an official ESPHome release.

The version string "25.11.20.1" is ApolloAutomation internal device firmware versioning, not an ESPHome release. Official ESPHome versions follow the format 2025.9.0, 2025.10.0, etc., and 25.11.20.1 does not exist in ESPHome's official changelog. Add documentation to Core.yaml explaining this is a device firmware build version and its relationship to the underlying ESPHome version (currently targeting ESPHome 2025.8.0 based on recent fixes).

Likely an incorrect or invalid review comment.

Integrations/ESPHome/R_PRO-1_W.yaml (1)

14-14: No action required. ESPHome version 2025.11.0 is a stable, officially released version with published changelog and migration documentation. The version constraint update is valid.

Integrations/ESPHome/Core.yaml

bharvey88 and others added 10 commits September 18, 2025 14:12

Merge pull request #33 from ApolloAutomation/ld2412-ld2450-name-id-na…

1eb772a

…me-fixes update ld2412 and ld2450 target entities with better names and better id names

fix copy paste mistake changing the ld2450 radar entitiy id and name

678eb12

fix copy paste mistake changing the ld2450 radar entitiy id and name

Merge pull request #36 from ApolloAutomation/remove_throttle_ld2450

5f5f6d3

Remove throttle filters from LD2450 targets

Remove throttle filters from LD2412 metrics

a6294b2

Removed throttle filters from various LD2412 metrics.

Update minimum version requirement to 2025.11.0 because the ld2412 fi…

54396af

…xes are not present before this version

Update minimum version requirement to 2025.11.0 because the ld2412 fi…

dc0996e

…xes are not present before this version

update version number

da0bd84

Merge pull request #38 from ApolloAutomation/ld2412-remove-filters

7d2cdf8

Remove throttle filters from LD2412 metrics

github-actions bot assigned TrevorSchirmer Dec 2, 2025

github-actions bot requested a review from TrevorSchirmer December 2, 2025 19:54

coderabbitai bot reviewed Dec 2, 2025

View reviewed changes

Integrations/ESPHome/Core.yaml Show resolved Hide resolved

TrevorSchirmer added the bugfix label Dec 2, 2025

TrevorSchirmer merged commit cdadef2 into main Dec 2, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge beta to main which brings in fixes for ld2412 and ld2450 stuck targets #39

Merge beta to main which brings in fixes for ld2412 and ld2450 stuck targets #39

Uh oh!

bharvey88 commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Merge beta to main which brings in fixes for ld2412 and ld2450 stuck targets #39

Merge beta to main which brings in fixes for ld2412 and ld2450 stuck targets #39

Uh oh!

Conversation

bharvey88 commented Dec 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix?

Types of changes

Checklist / Checklijst:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated Code Review Effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bharvey88 commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading