Add support for LD2450 to use the set presence timeout. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New ld2450 Library, New Updates
Currently the yaml has a bug where the timeout for presence is ignored because we have lines in the yaml missing. We will likely need to add this to the r-pro-1 yaml as well since it also uses the LD2450. More info from keith at ESPHome here: esphome/issues#7006 (comment)
Member
|
@bharvey88 Can you update the version number? Otherwise looks good. Also need to fill out one of the checkboxes in the future. It is what auto applies the correct label. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the yaml has a bug where the timeout for presence is ignored because we have lines in the yaml missing.
We will likely need to add this to the r-pro-1 yaml as well since it also uses the LD2450.
More info from keith at ESPHome here: esphome/issues#7006 (comment)
Version:
What does this implement/fix?
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified: