Skip to content

Conversation

@kbx81
Copy link

@kbx81 kbx81 commented Aug 13, 2025

Version:

What does this implement/fix?

Updates custom filters to mimic behavior from earlier releases by adding (new, otherwise-default) throttling back to the various sensors.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Updates

    • Version updated to 25.8.12.1
  • Performance

    • Sensors now throttle update reporting to 1000ms intervals for improved efficiency.

✏️ Tip: You can customize this high-level summary in your review settings.

@TrevorSchirmer TrevorSchirmer changed the base branch from main to beta December 3, 2025 20:19
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Walkthrough

Version bump from 25.8.6.1 to 25.8.12.1 in ESPHome configuration with addition of throttle_with_priority filters (1000ms) to five sensor definitions to regulate reporting frequency without altering underlying sensor logic.

Changes

Cohort / File(s) Summary
ESPHome Configuration Update
Integrations/ESPHome/Core.yaml
Version substitution incremented from 25.8.6.1 to 25.8.12.1. Added throttle_with_priority: 1000ms filters to five sensor definitions: moving_distance, still_distance, radar_moving_energy, radar_still_energy, and radar_detection_distance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with straightforward configuration updates
  • Repetitive filter additions follow consistent pattern across sensors
  • No logic changes or complex interactions to verify

Poem

🐰 A version climbs from six to twelve,
Five sensors now their impulses shelve,
With throttle restraint, one second's delay,
The data flows smoother, hip-hop-hooray! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update for ESPHome 2025.8.0 release' is vague and overly broad; it doesn't specify the actual changes made (throttle filter additions and version bump), making it unclear what the primary modification is. Consider a more specific title like 'Add throttle_with_priority filters to LD2410 sensors' or 'Restore sensor throttling behavior in ESPHome 2025.8.x' to better convey the main change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8e37d9 and eea9485.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml (4 hunks)
🔇 Additional comments (2)
Integrations/ESPHome/Core.yaml (2)

3-3: Version bump to 25.8.12.1 for ESPHome 2025.8.0 release.

The version number update aligns with the PR objectives for the ESPHome 2025.8.0 release and appears reasonable as a patch-level increment within the 25.8.x series.


379-379: Confirm throttle values match the intended behavior.

The filters apply a uniform 1000ms throttle across five radar-related sensors without specifying priority values. Verify that:

  • 1000ms (1 second) is the correct throttle window to restore earlier behavior
  • Omitting priority value: list is the intended configuration for these sensors

Consider documenting (in comments or commit message) why 1000ms was chosen and what behavior this restores.

Also applies to: 408-408, 437-437, 445-445, 453-453

@TrevorSchirmer TrevorSchirmer merged commit e5d868c into ApolloAutomation:beta Dec 3, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants