Skip to content

Conversation

@h3ss
Copy link
Contributor

@h3ss h3ss commented Feb 19, 2025

Version:
25.2.19.1

Adds:
NA

Fixes:
Remove rmt_channel from configuration to make it compatible with ESPHome 2025.2.0

Breaks:
Compatibility with older versions of ESPHome

Checks:

  • Documentation Updated
  • Build Number Incremented In YAML (YY.MM.DD.#)

@TrevorSchirmer
Copy link
Member

Thanks for the PR!! We don't typically update the ESPHome min_version unless there is some breaking change in it because then users are forced to update to use the sensor. I think it will still work fine if we leave the min_version, thoughts?

@h3ss
Copy link
Contributor Author

h3ss commented Feb 20, 2025

You're very welcome! I bumped the min_version because I assumed that prior versions of ESPHome might require the rmt_channel setting that was removed. Unfortunately I have no easy way to test this because I didn't keep a backup of the old ESPHome Builder. If you're sure it will still work on older versions without rmt_channel, keeping the old min_version makes sense to me.

@TrevorSchirmer
Copy link
Member

Talked with Jesse @ ESPHome and since this change isn't compatible with older versions we do indeed need to update the min_version so older versions can't compile it. Thanks for bringing this up!

@TrevorSchirmer TrevorSchirmer merged commit 4f6d846 into ApolloAutomation:main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base MSR-2 Configuration Invalid For ESPHome Device Builder Version 2025.2.0

2 participants