Skip to content

Conversation

@Bunton33
Copy link
Contributor

@Bunton33 Bunton33 commented Nov 26, 2025

Version: 2025.11.26.2

What does this implement/fix?

-Fix source link

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Bug Fixes
    • Corrected firmware update source configuration.
  • Chores
    • Updated version to 25.11.26.2.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

Two YAML configuration files in the ESPHome integration were updated: a version number increment in Core.yaml and a firmware manifest source path correction in H-2.yaml.

Changes

Cohort / File(s) Change Summary
Version Update
Integrations/ESPHome/Core.yaml
Bumped substitutions.version from "25.11.26.1" to "25.11.26.2"
Firmware Manifest Path
Integrations/ESPHome/H-2.yaml
Updated firmware_update HTTP request manifest source from firmware2/manifest.json to firmware/manifest.json

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify the version bump aligns with release practices
  • Confirm the firmware manifest path change (firmware2firmware) matches the actual endpoint structure

Poem

🐰 A version hops along the way,
And paths are fixed to work today,
Two little tweaks, so clean and neat,
Make ESPHome's config complete! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix source link' is vague and generic. While it references a real change (firmware manifest source link in H-2.yaml), it doesn't clearly convey what was actually fixed or why. Consider a more descriptive title like 'Fix firmware manifest source path in H-2' or 'Update firmware manifest endpoint' to better clarify the specific change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ResartFix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16574d8 and 212fef6.

📒 Files selected for processing (2)
  • Integrations/ESPHome/Core.yaml (1 hunks)
  • Integrations/ESPHome/H-2.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Building Integrations/ESPHome/H-2D.yaml / ESPHome dev / ESPHome dev
  • GitHub Check: Building Integrations/ESPHome/H-2.yaml / ESPHome dev / ESPHome dev
  • GitHub Check: Building Integrations/ESPHome/H-2.yaml / ESPHome stable / ESPHome stable
  • GitHub Check: Building Integrations/ESPHome/H-2D.yaml / ESPHome stable / ESPHome stable
  • GitHub Check: Building Integrations/ESPHome/H-2.yaml / ESPHome beta / ESPHome beta
  • GitHub Check: Building Integrations/ESPHome/H-2D.yaml / ESPHome beta / ESPHome beta
🔇 Additional comments (2)
Integrations/ESPHome/H-2.yaml (1)

95-100: LGTM! Source link corrected.

The manifest URL has been corrected from the incorrect firmware2 path to the proper firmware path, which aligns with the PR objective. The change is minimal and focused.

Since the PR confirms local testing, please verify that the new endpoint https://apolloautomation.github.io/H-2/firmware/manifest.json is accessible and contains the expected firmware manifest. If this resolves an existing issue where firmware updates were failing, confirming the availability of the corrected URL would be helpful.

Integrations/ESPHome/Core.yaml (1)

1-2: Version bump approved.

The patch-level version increment from 25.11.26.1 to 25.11.26.2 appropriately reflects the source link bugfix being released.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bugfix Something isn't working label Nov 26, 2025
@Bunton33 Bunton33 merged commit 407d9b7 into main Nov 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants