Skip to content

Conversation

@Qnbie
Copy link

@Qnbie Qnbie commented Jan 5, 2026

It's a fix for the #146 issue. If the two transaction ID is the same, it throws an error and rebuilds the connection.

@LanderV-Vintecc
Copy link

Shouldn't the response be ignored if the transaction id is different, instead of throwing an exception? Throwing will result in no data being read and thus data loss.

@Qnbie
Copy link
Author

Qnbie commented Jan 7, 2026

The data loss will also occur, if we just ignore the response. With an exception at least we know about that and also reconnection could happen.

@LanderV-Vintecc
Copy link

It would require a larger change, but you could keep in memory the responses for the different transaction id's, waiting until the response for "your" id is received, and then continue. Out of order responses are a part of the protocol, so this does not indicate a "bad" connection, so a reconnect is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants