Ha fixing advanced options datasheet

[hfadams]

• fixed error with manualThreshold data type when building advancedClassifierOptions datasheet
• updated advancedClassifierOptions datasheet to save the tuning objective, manual threshold, and seed value in results scenario
• fixed error in histogram function when CNN model is selected

NOTE: did not update package version, will be included in release for version 2.3.2

Summary by CodeRabbit

• New Features

  • Added tuningObjective and setSeed to advanced classifier settings.
  • Predict step now accepts classifier option inputs so prediction can use the same configuration sheets as training.

• Bug Fixes

  • Improved default handling for classifier options (manualThreshold, tuningObjective, setSeed) when not provided.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

.coderabbit.yml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'code_guidelines', 'ai'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

📝 Walkthrough

Walkthrough

Adds NULL-default handling for classifier option variables and appends tuningObjective and setSeed to the advanced classifier options output; renames CNN prediction references from predict_cnn_dataframe to predictCnnDataframe; and exposes classifier options and raster output datasheets in the Predict transformer.

Changes

Cohort / File(s)	Summary
Advanced Classifier Options Updates src/1-train-classifier.R	Ensure manualThreshold, tuningObjective, and setSeed are reset to "" when NULL. Add tuningObjective and setSeed columns to advClassifierOptionsOutputDataframe and populate them in final output.
CNN Prediction API Alignment src/functions/0.4-CNN.r, src/functions/0.5-histogram.r	Rename usage from predict_cnn_dataframe → predictCnnDataframe: update warning text in 0.4-CNN.r and call site in the CNN branch of 0.5-histogram.r.
Predict Transformer Manifest src/package.xml	Add ClassifierOptions and AdvancedClassifierOptions as Input datasheets and add RasterOutput as a Both datasheet for transformer 2 (Predict).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Ha improving training efficiency #38 — Adds and propagates a tuningObjective classifier option; directly related to tuningObjective additions.
• moved the over ride band names earlier #43 — Propagates setSeed through advanced options and wiring; closely related to setSeed handling.
• Switch post-processing order #46 — Modifies advanced classifier options surface and Predict transformer inputs; aligns with datasheet and option changes here.

Suggested reviewers

• afilazzola

Poem

🐰 I hop through code in tidy rows,

Nulls turned empty where logic flows.
Two new columns, seed and aim,
CNN names fixed to match the game.
A small soft hop — the build now grows.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Ha fixing advanced options datasheet' is partially related to the changeset. While it mentions fixing the advanced options datasheet, it omits other significant changes: updating the Predict transformer with new datasheets, fixing the CNN model function call in the histogram function, and handling new default values for classifier options.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b24797b and 847db6c.

📒 Files selected for processing (1)

• src/package.xml

🚧 Files skipped from review as they are similar to previous changes (1)

• src/package.xml

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}