Skip to content

[#202] fix: resolved UI inconsistencies on product details page#204

Open
Pranaykarvi wants to merge 5 commits intoAnwishta:mainfrom
Pranaykarvi:fix-ui
Open

[#202] fix: resolved UI inconsistencies on product details page#204
Pranaykarvi wants to merge 5 commits intoAnwishta:mainfrom
Pranaykarvi:fix-ui

Conversation

@Pranaykarvi
Copy link
Copy Markdown

🛠️ Fix: Resolved UI Inconsistencies on Product Details Page

🔍 Issue

This PR fixes UI inconsistencies in the Favorites.js component, addressing Issue #202.

✨ Changes Made

  • 📌 Centered the sorting dropdown for better alignment.
  • 🎨 Improved button styling to ensure consistency across the app.
  • 🔍 Enhanced empty state message for better readability.
  • 🖼 Fixed image scaling issues using aspect-square to maintain aspect ratio.
  • Optimized sorting logic using useMemo() to improve performance.

✅ How to Test

  1. Navigate to Favorites Page (/favorites).
  2. Ensure that:
    • Sorting dropdown is aligned properly.
    • Buttons have a consistent hover effect and design.
    • Empty state text is clearly visible.
    • Product images are properly scaled.
    • Sorting works as expected (cheapest → most expensive).

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 7, 2025

@Pranaykarvi is attempting to deploy a commit to the anwishta's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shop-sphere ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 7:29am
shop-sphere-2n6k ❌ Failed (Inspect) Feb 25, 2025 7:29am

@Anwishta
Copy link
Copy Markdown
Owner

Anwishta commented Feb 8, 2025

@Pranaykarvi solve the merge conflicts

@Pranaykarvi
Copy link
Copy Markdown
Author

@Anwishta Is there any other changes? @GauravKesh has approved so if everything is ok can we merge the pr?

Copy link
Copy Markdown
Owner

@Anwishta Anwishta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-25 233232

image
Address these problems. Deployment issue is occurring because of some bugs in your code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEGINNER bug Something isn't working good first issue Good for newcomers SWOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants