Skip to content

Featture/login attempt logic#16

Merged
zeedivx merged 2 commits intoAnvoria:mainfrom
CarlosOchoa8:featture/login-attempt-logic
Jul 16, 2025
Merged

Featture/login attempt logic#16
zeedivx merged 2 commits intoAnvoria:mainfrom
CarlosOchoa8:featture/login-attempt-logic

Conversation

@CarlosOchoa8
Copy link
Contributor

I worked in #3 but doing it, i considered that adding just one func to reset redis key after cleaning up as you say

_reset_failed_attempts() - clears Redis counter (called on successful login)

would be over-abstracted for only 1 code lane. But id like to hear your thoughts.
This is how i managed the issue, although the most important part is to implement these funcs into
async def authenticate_user(self, login_data: LoginRequest) -> TokenResponse:

Glad to hear you feedback!

@zeedivx
Copy link
Contributor

zeedivx commented Jul 16, 2025

Thanks a lot for the PR!
Sorry it took me a while to get back to you - life's been chaotic and I haven't had time to work on this project lately.
That should change next week. Really appreciate your contribution and patience!

@zeedivx zeedivx merged commit 163cdcb into Anvoria:main Jul 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants