Skip to content

fix(dynamic): Android14 writable dex file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntonioShare merged 1 commit into from
Dec 24, 2024
Merged

fix(dynamic): Android14 writable dex file #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...ects/sdk/dynamic/dynamic-apk/src/main/java/com/tencent/shadow/dynamic/apk/ImplLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@

package com.tencent.shadow.dynamic.apk;

import android.os.Build;

import com.tencent.shadow.core.common.InstalledApk;

import java.io.File;
import java.lang.reflect.Field;
import java.util.Objects;

import dalvik.system.DexClassLoader;

Expand All @@ -35,6 +39,7 @@ public String[] loadWhiteList(InstalledApk installedApk) {
}

public String[] loadWhiteList(InstalledApk installedApk, String whiteListClassName, String whiteListFieldName) {
checkDexReadOnly(installedApk);
DexClassLoader dexClassLoader = new DexClassLoader(
installedApk.apkFilePath,
installedApk.oDexPath,
Expand Down Expand Up @@ -72,4 +77,13 @@ private static String[] concatenate(String[] a, String[] b) {
System.arraycopy(b, 0, c, aLen, bLen);
return c;
}

private static void checkDexReadOnly(InstalledApk installedApk) {
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.TIRAMISU) {
boolean readOnly = new File(Objects.requireNonNull(installedApk.apkFilePath)).setReadOnly();
if (!readOnly) {
throw new RuntimeException("apk file is not read only");
}
}
}
}
Loading