feat(inputbox): smooth scrolling (ex: search and dynamic playlist editing)#456
Merged
AnthonyMichaelTDM merged 18 commits intomainfrom Feb 5, 2026
Merged
feat(inputbox): smooth scrolling (ex: search and dynamic playlist editing)#456AnthonyMichaelTDM merged 18 commits intomainfrom
AnthonyMichaelTDM merged 18 commits intomainfrom
Conversation
scroll the visible text to ensure the cursor is always visible
…elete_next_char methods instead of repeatedly iterating over the string, use one iterator (only go over the text once)
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 80.39% 80.54% +0.14%
==========================================
Files 118 118
Lines 10070 10147 +77
==========================================
+ Hits 8096 8173 +77
Misses 1974 1974
|
AnthonyMichaelTDM
force-pushed
the
scroll-inputbox
branch
from
f95e9ce to
765f159
Compare
this will enable us to remove mutex's and refcells around component state
- Removed unnecessary use of Mutex and RefCell for tree states and input boxes in various components. - Updated the handling of key events and mouse events to directly interact with the state without locking. - Simplified the initialization of input boxes and tree states by removing RefCell and Mutex wrappers. - Improved readability and performance by reducing the complexity of state access patterns.
AnthonyMichaelTDM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should make the UX for editing dynamic playlist queries much better for long queries