Combine voting when 2 matches remaining in each group#2
Open
Syrefva wants to merge 2 commits intoAnimeThemes:mainfrom
Open
Combine voting when 2 matches remaining in each group#2Syrefva wants to merge 2 commits intoAnimeThemes:mainfrom
Syrefva wants to merge 2 commits intoAnimeThemes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently voting is combined once each group has just 1 match remaining (e.g. for a 4-group contest, voting is combined once we are in the quarterfinals). Luckily, the code is already set up to easily change that to more than 1 match since it works by checking the number of matches and then recursively calling the same function (
getBracketRounds) without a group specified in the case that we want to combine voting.Besides that, we update when the voting page text becomes "All Groups".
Note I haven't been able to test this.