Fix profile update #111
Merged
Fix profile update #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vigating to home.
…ed the pixabay images
|
This is a big PR, I'll take a look at it later |
doowoncho
reviewed
Feb 5, 2025
| } | ||
| } | ||
|
|
||
|
|
| fastlane/test_output | ||
|
|
||
| .DS_Store | ||
| FlatMate/Secrets.plist |
There was a problem hiding this comment.
do we all have to have a separate API key? Could we not just all use the same secrets.plist?
Contributor
Author
There was a problem hiding this comment.
nope we are all using the same Api key and obviously I cant push the secrets.plist file in the github because this repo is public and the key would get corrupted right
| // @State private var isImagePickerPresented = false | ||
| @State private var errorMessage: String? | ||
| @State private var selectedItem: PhotosPickerItem? = nil | ||
| // @State private var selectedItem: PhotosPickerItem? = nil |
There was a problem hiding this comment.
Oh so are we not gonna let users upload their own photos? Just using pixby?
Contributor
Author
There was a problem hiding this comment.
I dont have any problems with letting users adding their photos but you have upload pictures manually for them right so i feel like pixabay is a better way of solving the limited picture issues.
doowoncho
reviewed
Feb 5, 2025
| await MainActor.run { self.isLoading = false } | ||
| } | ||
| } | ||
|
|
Collaborator
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile was not updating properly. Needed to change the rules for the firebase storage to make it work.