Skip to content

test: add comprehensive backend test coverage for AI merge and project modules #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StillKnotKnown wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

test: add comprehensive backend test coverage for AI merge and project modules #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2a79ba1
Merge pull request #1880 from AndyMik90/develop
AndyMik90 Feb 20, 2026
a1a79ce
test: add comprehensive AI Context module tests (35 tests)
StillKnotKnown Mar 13, 2026
fd7ccfe
test: add comprehensive AI MCP module tests (75 tests)
StillKnotKnown Mar 13, 2026
cf88767
test: add comprehensive backend test coverage for AI merge and projec…
StillKnotKnown Mar 13, 2026
3cf7573
test: fix linting issues in new test files
StillKnotKnown Mar 13, 2026
3982906
fix: resolve all typecheck and test errors
StillKnotKnown Mar 13, 2026
afb8ece
test: increase timing threshold to 100ms for CI reliability
StillKnotKnown Mar 13, 2026
e084d44
test: use path.join for Windows compatibility in file-evolution test
StillKnotKnown Mar 13, 2026
99163db
test: fix Windows path compatibility across multiple test files
StillKnotKnown Mar 13, 2026
468cbb3
test: use platform-agnostic path matching for Windows CI
StillKnotKnown Mar 13, 2026
f43c2cd
test: make roadmap directory test platform-agnostic
StillKnotKnown Mar 13, 2026
cec137d
Merge remote-tracking branch 'upstream/main' into feat/backend-test-c…
StillKnotKnown Mar 13, 2026
acc40d4
ci: trigger status recalculation
StillKnotKnown Mar 13, 2026
675fa8f
Merge remote-tracking branch 'upstream/develop' into feat/backend-tes…
StillKnotKnown Mar 13, 2026
970ac5f
Merge branch 'develop' into feat/backend-test-coverage
StillKnotKnown Mar 13, 2026
8bb3eb8
test: improve backend coverage to 90%+ for merge and runners modules
StillKnotKnown Mar 13, 2026
6e37607
Merge branch 'develop' into feat/backend-test-coverage
StillKnotKnown Mar 13, 2026
293742b
test: improve backend coverage with additional module tests
StillKnotKnown Mar 13, 2026
640a4fe
test: improve coverage for merge and orchestration modules
StillKnotKnown Mar 13, 2026
0c0a9be
test: add orchestrator test coverage for build and spec pipelines
StillKnotKnown Mar 13, 2026
aca9f91
Merge branch 'develop' into feat/backend-test-coverage
StillKnotKnown Mar 14, 2026
b363e66
Merge branch 'develop' into feat/backend-test-coverage
AndyMik90 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/desktop/src/main/ai/config/__tests__/phase-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ describe('resolveModelId', () => {

beforeEach(() => {
process.env = { ...originalEnv };
// Clear model override env vars to ensure clean test state
delete process.env.ANTHROPIC_DEFAULT_OPUS_MODEL;
delete process.env.ANTHROPIC_DEFAULT_SONNET_MODEL;
delete process.env.ANTHROPIC_DEFAULT_HAIKU_MODEL;
});
Comment on lines +92 to 96
Copy link

@sentry sentry bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The performance test for observe() asserts a 100ms time limit, but the production code's requirement is under 2ms. The test is too permissive to catch regressions.
Severity: HIGH

Suggested Fix

Update the test assertion in memory-observer.test.ts to match the production requirement. Change expect(elapsed).toBeLessThan(100) to expect(elapsed).toBeLessThan(2). If this causes test flakiness in CI, investigate and stabilize the test environment or the code under test rather than using a lenient threshold.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/desktop/src/main/ai/config/__tests__/phase-config.test.ts#L92-L96

Potential issue: The performance test for the `observe()` function in
`memory-observer.ts` has an assertion that is 50 times too permissive. The production
code and its documentation specify a performance budget of less than 2ms, logging a
warning if this is exceeded. However, the test only validates that the execution time is
less than 100ms (`expect(elapsed).toBeLessThan(100)`). This discrepancy means the test
will pass even for code that is significantly slower than the required budget, failing
to catch performance regressions that would trigger warnings in a production
environment.

Did we get this right? 👍 / 👎 to inform future reviews.


afterEach(() => {
Expand Down
Loading
Loading