Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/beta-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ jobs:

- name: Sign Windows executable with Azure Trusted Signing
if: env.AZURE_CLIENT_ID != ''
uses: azure/trusted-signing-action@v0.5.11
uses: azure/trusted-signing-action@v1.1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The release workflow uses a deprecated repository path and input parameter for the code signing action, which will cause the build to fail.
Severity: CRITICAL

Suggested Fix

Update the workflow to use the new action path Azure/artifact-signing-action@v1.1.0 and replace the deprecated input trusted-signing-account-name with signing-account-name.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/beta-release.yml#L282

Potential issue: The workflow file `beta-release.yml` uses an outdated configuration for
the code signing GitHub Action. The action's repository has been moved from
`azure/trusted-signing-action` to `Azure/artifact-signing-action`, and the input
parameter `trusted-signing-account-name` has been deprecated in favor of
`signing-account-name`. This misconfiguration will cause the signing step to fail during
the release workflow, preventing the creation and distribution of signed Windows
binaries.

with:
endpoint: https://neu.codesigning.azure.net/
trusted-signing-account-name: ${{ secrets.AZURE_SIGNING_ACCOUNT }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ jobs:

- name: Sign Windows executable with Azure Trusted Signing
if: env.AZURE_CLIENT_ID != ''
uses: azure/trusted-signing-action@v0.5.11
uses: azure/trusted-signing-action@v1.1.0
with:
endpoint: https://neu.codesigning.azure.net/
trusted-signing-account-name: ${{ secrets.AZURE_SIGNING_ACCOUNT }}
Expand Down