Skip to content

Conversation

@FabulousCupcake
Copy link

@FabulousCupcake FabulousCupcake commented Aug 9, 2021

Changes in this PR:

  • Adds Days to EN Release and Expected EN Release Date columns to all jp-history pages.
  • Makes jp-history/features dope
  • Adds html flag to DopeAssTable to allow raw html displayName for table heading

@vercel
Copy link

vercel bot commented Aug 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anducrandu/pricalc/3zWZ6arDxMbFq5XSXjWFBzrf3b2c
✅ Preview: https://pricalc-git-fork-fabulouscupcake-patch-nicer-a9926c-anducrandu.vercel.app

@FabulousCupcake
Copy link
Author

FabulousCupcake commented Aug 9, 2021

Feels like these pages should have user-inputtable offset of days to adjust for the shift in schedule in EN:
Tomo's expected release date is 3 August 2021, but we're likely getting her on the next banner (18 August 2021) so it's off by 15 days — would be really nice if this offset could be applied to the rest of the page.

Alternatively it doesn't need to be user-inputtable; just hardcoded 15 days offset, put somewhere in the codebase, and shown to the user that it assumes 15 days offset.

Edit: I made a PR for this too: see the PR linked below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant