Feature/auth #3
Open
Feature/auth #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmenenko
reviewed
Nov 28, 2022
src/iap/modules/auth/components/signup-form/signup-form.component.ts
Outdated
Show resolved
Hide resolved
src/iap/modules/auth/components/signup-form/signup-form.component.html
Outdated
Show resolved
Hide resolved
evmenenko
reviewed
Jan 10, 2023
| @@ -1,11 +1,25 @@ | |||
| import { NgModule } from '@angular/core'; | |||
| import { NgModule, isDevMode } from '@angular/core'; | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| import { NgModule, isDevMode } from '@angular/core'; | |
| import { NgModule } from '@angular/core'; |
| type="submit" | ||
| class="iap-signup-form__submit-button" | ||
| value="Sign Up" | ||
| [disabled]="signupForm | isControlInvalid" |
Collaborator
There was a problem hiding this comment.
Suggested change
| [disabled]="signupForm | isControlInvalid" | |
| [disabled]="signupForm.invalid" |
| styleUrls: ['./signup-form.component.scss'], | ||
| }) | ||
| export class SignupFormComponent implements OnInit { | ||
| @Output() submitEvent: EventEmitter<ApiResponse> = new EventEmitter(); |
Collaborator
There was a problem hiding this comment.
I think we have already discussed this topic, but when your variable can define its type automatically you haven't to add pure typing.
Suggested change
| @Output() submitEvent: EventEmitter<ApiResponse> = new EventEmitter(); | |
| @Output() submitEvent = new EventEmitterr<ApiResponse>(); |
Comment on lines
+19
to
+21
| return this.api.post(url, { login, password }).pipe( | ||
| tap((res: any) => this.setSession(res as JwtSession)), | ||
| shareReplay(), |
Collaborator
There was a problem hiding this comment.
Use your new possibilities!
Suggested change
| return this.api.post(url, { login, password }).pipe( | |
| tap((res: any) => this.setSession(res as JwtSession)), | |
| shareReplay(), | |
| return this.api.post<JwtSession>(url, { login, password }).pipe( | |
| tap((res) => this.setSession(res)), | |
| shareReplay(), |
| const url = apiRoutesAuth.loginAdimn; | ||
| return this.api.post(url, { login, password }).pipe( | ||
| tap((res: any) => this.setSession(res as JwtSession)), | ||
| shareReplay(), |
Collaborator
There was a problem hiding this comment.
Remind me what is the reason to use shareReplay here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.