Integrate Raphaels refactor, package structure, and documentation#4
Open
andreas-prein wants to merge 73 commits intoAndreasPrein:mainfrom
Open
Integrate Raphaels refactor, package structure, and documentation#4andreas-prein wants to merge 73 commits intoAndreasPrein:mainfrom
andreas-prein wants to merge 73 commits intoAndreasPrein:mainfrom
Conversation
… is to use all slices and connect labels)
…ference. 2d is only faster for jetstreams, because of large extent.
…d, approx. half of the time is in the watershedding methods, which takes even more time for larger datasets.
… the kDtree of the labelling process
…e current code to
…not measured with prof, but with original data, 2d was 40s, 3d was 20s and parallel is 15s total, where the constant time to save to .nc file is included)
…y footprint and see if parallel execution could be good.
…makes most sense.
…distribution and when to use single core and when the parallel version
…e ratio of the picture is x:y, if x>y the chunking should also be such that x>y
add of more comments and function description, add of check for sequential and parallel code depending on memory usage and also add default chunking strategy, if none is given.
…roducing shared memory, with the exact same (+-0.05%) result as in the sequential algorithm. Add Documentation for new functions
…links old module with new folder structure.
…acy_psl_tracking function, the labeling was not removed, since this changes the endresult of the function.
…an be simulated, by just giving 1 as input for both chunksizes. Additionally, an mp_method was defined based on the findings on Euler, of when the data generates a timeout. If that is the case, spawn should be used. Generally, fork is better for small problems, whereas spawn has nearly no overhead for large problems (i.e. >400M cells in all dimensions)
… min_js_anomaly from upper level call and use definition from the config file. Update tutorial and correction of a second bug, when trying to call watershed with just one total chunk
…omatic choosing of multiprocessing method and default of number of processes set to 'None'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the major refactoring and extensions developed by Raphael Graf
into the main MOAAP repository.
Key changes:
The repository license remains GPL-3.0. Legacy entry points are preserved.