Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add dark-mode, since we are getting compiler warnings that the Palette is deprecated and we should change to PaletteLight (+ PaletteDark).
This uses the system default preference on first render, but if the user actively changes the setting it is supposed to stay changed (currently, this restarts on full refresh / navigate to page anew but not on navigating through the site - see subtasks).
Most of the colors are based on what @marfavi liked, though in my opinion the dark mode is a little too dark...? But please help me with inputs on this :) I have attempted to find a good text-color that can be used instead.
I am also considering "bundling" same colors together (such that we don't define the textcolor three different places to be the same value).
Subtasks
This PR is a draft and is missing two main features: