Add support for Fahrenheit in the weather block #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vKnmnn
requested changes
Feb 20, 2020
Collaborator
vKnmnn
left a comment
vKnmnn
left a comment
There was a problem hiding this comment.
please don't change the default temperature thresholds to some values on a very unscientific scale ;)
please do add your defaults as URGENT_LOWER_FAHRENHEIT or something like that and add a config option to select metric or imperial system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extended the weather block and simplified the switch to Fahrenheit. Celsius is still enabled by default.