Update ankiaddonconfig #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad2d249 make ConfigWindow a Modal fixes bug on Anki where after opening 'Advanced' in ConfigWindow, close button in main Anki window disappears even after closing f4bc2bc remove WA_DeleteOnClose property 52fdc92 update README 52ed3fe format with black 5cf729e mypy ignore line 7d7faba qt enum values must be namespaced direct value access is no longer supported 254973e feat: Add `shortcut_input` to `ConfigLayout` (#2) 92ed29e Merge pull request #3 from RisingOrange/fix/dropdown-key-values 8146103 fix: dropdown - set value instead of label 954c030 Merge pull request #1 from chuanqixu/master 48422f3 update/changes when QComboBox items are changed b160071 fix conf.get() not deep-copying object 29b47c4 fix color input dialog not showing current color ff4e8c2 update ankiaddonconfig README 21c34a3 add instructions to use git subtree to use ankiaddonconfig git-subtree-dir: src/addon/ankiaddonconfig git-subtree-split: ad2d2495a3aa72e98bcb3013955b7e4558e36477
Collaborator
|
Thanks @BlueGreenMagick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
#41 seems to have been caused by the following line, combined with a Qt bug:
This PR also fixes another issue (which might be another Qt bug as well?) where after opening advanced config editor then closing them, the 'close' button in MacOS window bar becomes disabled.