Conversation
* So far so good * set list set list set list set list * wip * Refactoring going strong * it goes it goes it goes * Add test suit * Working base query * Prep for next session * Working WikiPage generation * Add langlinks to WikiPage * General structure for fetchers * Flawlessly wasting time doing banger logs * Disabling verbose test * Clean * Add wiki_quote method * Add description in fetcher for base infos + docstring * Add tests for WikiPage * Fix error in WikiQuery * Pre-commit + Add backlinks * Multiple fetchers * Fix bugs * Add fetcher for pageviews * Fix fetch_revisions (datetime was wrong) * Page assessments can be None * Tests for WikiPage * Tests added for export * Remove get_from_wikipedia * Exporting * Testing export * Update dashboard
* New version, working UI * Working loading data and individual pages * Fix error processing * Change button size * Fix Dashboard * Error handling in Dashboard * Buttons * Add num errors and matches * Moar nums * Remove empty * More infos for result * Remove not found pages from pool of individual pages
Amustache
commented
Apr 8, 2024
| target_langs: str | Iterable[str] = None # Languages to seek for | ||
| last_updated: datetime.datetime = datetime.datetime.now() # When was the query made | ||
| target_duration: int = DEFAULT_DURATION # Number of days for contributions | ||
| granularity: str = "daily" # Granularity for contributions |
Owner
Author
There was a problem hiding this comment.
Change to constant in helpers (GRANULARITY, https://github.com/Amustache/Wikipedia-Analysor/pull/39/files#diff-219bae082311a5b1c404a801280e2d0924032ca22622026e8baeb16242cbb38fR20)
Amustache
commented
Apr 8, 2024
| # At least one revision | ||
| min_score = 1 | ||
| # https://en.wikipedia.org/wiki/Special:MostRevisions | ||
| max_score = 50_000 |
Owner
Author
There was a problem hiding this comment.
Should be 50'000 divided by max days - here, 50'000 since when?
Amustache
commented
Apr 8, 2024
| # return NotImplementedError | ||
| min_score = 1 | ||
| max_score = 100 | ||
| score = 50 |
| # return NotImplementedError | ||
| min_score = 1 | ||
| max_score = 100 | ||
| score = 50 |
| min_score = 1 | ||
| # https://en.wikipedia.org/wiki/Wikipedia:Popular_pages#Top-100_list | ||
| max_score = 100 | ||
| score = 50 |
| min_score = 1 | ||
| # | ||
| max_score = 100 | ||
| score = 50 |
| + _score_recent_revisions(wikipage.revisions) | ||
| + _score_backlinks(wikipage.backlinks) | ||
| + _score_pageviews(wikipage.pageviews) | ||
| ) / 6 |
| + _score_recent_revisions(wikipage.revisions) | ||
| + _score_pageassessments(wikipage.pageassessments) | ||
| + _score_fres(wikipage.readability["fres"]) | ||
| ) / 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.