Skip to content

Conversation

@migthymax
Copy link
Member

I have no idea if I correctly created the patch file. What makes me somehow suspicious is that in the patch file for every commit at the end the line 2.43.0 appears, no idea where it comes from!

To build a native binutils (without working gdb), it is recommended to use the docker image walkero/amigagccondocker:os4-gcc11 and within that running container performing the following steps as user amidev:

mkdir native-build
cd mkdir native-build
CFLAGS="-mcrt=clib4 -Wno-sign-compare -gstabs -fno-omit-frame-pointer -lpthread -athread=native" CXXFLAGS="-mcrt=clib4 -Wno-sign-compare -gstabs -fno-omit-frame-pointer -lpthread -athread=native" ../configure --disable-gdb --disable-plugins --disable-sim --disable-nls --host=ppc-amigaos --target=ppc-amigaos --prefix=/opt/code/dist

Make sure that the /opt/code/distexits, or adjust it to your needs!

Oh an by the way it needs clib4 at least version 2.0

Copy link

@walkero-gr walkero-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the patch was created properly. There are a lot of changes.
Is it possible to leave the first patch as it was and create a second one with your latest changes?

Date: Tue, 10 Jan 2023 11:51:55 +0100
Subject: [[PATCH] Changes for compiling binutils 2.40 for AmigaOS 4 using clib4 02/61]
Initial appling adtools binutils patches with focus on AmigaOS ELF only
support

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your patch have multiple places where similar sections exist. This is not right. This should exist only one time in every diff. Did you use the gild to create the patch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I didn't use glid, I used git to export all commits added an the branch as patches, like thgis:

git format-patch --stdout <start>^..<branch-or-end> > <patch-file>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that this is not going to work. All the patches need to be created with gild.
I can help you with that if you like, and create a new patch that contains only the changes for the native version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using glid isn't that complicated, maybe write here short instruction how to use it for creating the patch files. So as to have here a sort documentation for it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. What you do is

  1. you make the code changes in the binutils/repo folder
  2. Then create a COMMIT for the changes, without pushing it. So you use git add . and git commit -m "write a useful message here"
  3. You come out of the binutils repo, cd ..
  4. and then you run gild genpatch binutils 2.40

The patch is auto-generated for you
What gild also does is modify all the previous patches too
Then you need to commit and push all the amendments made by gild's genpatch in the adtools repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants