-
Notifications
You must be signed in to change notification settings - Fork 3
Updated single patch file for binutils 2.40 AmigaOS4 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
walkero-gr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the patch was created properly. There are a lot of changes.
Is it possible to leave the first patch as it was and create a second one with your latest changes?
| Date: Tue, 10 Jan 2023 11:51:55 +0100 | ||
| Subject: [[PATCH] Changes for compiling binutils 2.40 for AmigaOS 4 using clib4 02/61] | ||
| Initial appling adtools binutils patches with focus on AmigaOS ELF only | ||
| support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your patch have multiple places where similar sections exist. This is not right. This should exist only one time in every diff. Did you use the gild to create the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I didn't use glid, I used git to export all commits added an the branch as patches, like thgis:
git format-patch --stdout <start>^..<branch-or-end> > <patch-file>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid that this is not going to work. All the patches need to be created with gild.
I can help you with that if you like, and create a new patch that contains only the changes for the native version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If using glid isn't that complicated, maybe write here short instruction how to use it for creating the patch files. So as to have here a sort documentation for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. What you do is
- you make the code changes in the binutils/repo folder
- Then create a COMMIT for the changes, without pushing it. So you use
git add .andgit commit -m "write a useful message here" - You come out of the binutils repo,
cd .. - and then you run
gild genpatch binutils 2.40
The patch is auto-generated for you
What gild also does is modify all the previous patches too
Then you need to commit and push all the amendments made by gild's genpatch in the adtools repository
I have no idea if I correctly created the patch file. What makes me somehow suspicious is that in the patch file for every commit at the end the line
2.43.0appears, no idea where it comes from!To build a native binutils (without working gdb), it is recommended to use the docker image
walkero/amigagccondocker:os4-gcc11and within that running container performing the following steps as useramidev:Make sure that the
/opt/code/distexits, or adjust it to your needs!Oh an by the way it needs
clib4at least version2.0