Minor changes to imporve conziseness and readebility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doertydoerk
commented
Jan 10, 2015
doertydoerk
commented
- replace UI related code with storyboard capabilities to reduce amount of code
- introduces IBAction to launch popup view
- move code out of viewDidLoad: and into showPopupView:(UIButton *)sender for lazy instantiation
- alted method and ivar naming
- accessing ivars via self. as I figured it's pointless to have getter/setter for non-public ivars and then bypassing them
- replace UI related code with storyboard capabilities to reduce amount of code - introduces IBAction to launch popup view - move code out of viewDidLoad: and into showPopupView:(UIButton *)sender for lazy instantiation - alted method and ivar naming - accessing ivars via self. as I figured it's pointless to have getter/setter for non-public ivars and then bypassing them
Author
|
Nice job, mate! Will give you credit on Cocoa Controls once implemented in my app and available on the app store. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.