Skip to content

Sonarqube workflow#14

Open
BushraAsif wants to merge 2 commits intomainfrom
sonarqube-workflow
Open

Sonarqube workflow#14
BushraAsif wants to merge 2 commits intomainfrom
sonarqube-workflow

Conversation

@BushraAsif
Copy link
Contributor

No description provided.

Copy link
Contributor

@shahbaz-mehar shahbaz-mehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been reviewed.

@@ -0,0 +1 @@
sonar.projectKey=AltaPay_sdk-js_876464ac-e665-4630-b509-40c868aead97
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that we can expose here? Or shouldn't this be an action secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be exposed. The project key is not sensitive, only the Sonar token and Sonar Host needs to be kept as an action secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants