Feature/touch ups/dhiren #165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applied a consistent toolbar style (`ToolBarTitle`, `ToolButtonIcon`) to `fragment_wallet_add.xml`, `fragment_budget_main.xml`.
- Updated `fragment_wallet_add.xml`:
- Replaced existing toolbar content with a standardized `LinearLayout` containing back button, title, and a placeholder ImageButton.
- Adjusted margins for the toolbar content.
- Updated `fragment_budget_main.xml`:
- Replaced the existing title `TextView` with a new `AppBarLayout` and `Toolbar`.
- Implemented the standardized toolbar structure with a back button, "Current Budgets" title, and a placeholder ImageButton.
- Adjusted constraints to position content below the new app bar.
- Updated `fragment_achievements.xml`:
- Changed the `src` of two `ImageView`s from `ic_ui_circle_check` to `ic_ui_security_lock`.
- Applied a consistent toolbar style (`ToolBarTitle`, `ToolButtonIcon`) to `fragment_wallet_add.xml`, `fragment_budget_main.xml`.
- Updated `fragment_wallet_add.xml`:
- Replaced existing toolbar content with a standardized `LinearLayout` containing back button, title, and a placeholder ImageButton.
- Adjusted margins for the toolbar content.
- Updated `fragment_budget_main.xml`:
- Replaced the existing title `TextView` with a new `AppBarLayout` and `Toolbar`.
- Implemented the standardized toolbar structure with a back button, "Current Budgets" title, and a placeholder ImageButton.
- Adjusted constraints to position content below the new app bar.
- Updated `fragment_achievements.xml`:
- Changed the `src` of two `ImageView`s from `ic_ui_circle_check` to `ic_ui_security_lock`.
…ps/dhiren # Conflicts: # app/src/main/assets/version.txt # app/src/main/res/layout/fragment_wallet_add.xml
- Added a comprehensive list of new `IconItem` entries to the `_icons` list in `CategoryAddNewViewModel.kt`. This significantly increases the variety of icons users can choose from when creating new categories. - Removed a specific `app` run configuration selection state from `.idea/deploymentTargetSelector.xml`.
- Added a comprehensive list of new `IconItem` entries to the `_icons` list in `CategoryAddNewViewModel.kt`. This significantly increases the variety of icons users can choose from when creating new categories. - Removed a specific `app` run configuration selection state from `.idea/deploymentTargetSelector.xml`.
…ps/dhiren # Conflicts: # app/src/main/assets/version.txt
- Set `android:visibility="invisible"` for `btnGoBack` in `fragment_budget_main.xml`. - Set `android:visibility="invisible"` for the placeholder `ImageButton` in the toolbar in `fragment_budget_main.xml`.
…ps/dhiren # Conflicts: # app/src/main/assets/version.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
What’s this PR about? 🤔
Describe briefly what this Pull Request is doing. Explain the problem it solves or the feature it adds to the project.
Why are we doing this? 💡
Explain why these changes are necessary.
Type of Change 🛠️
What kind of change does this Pull Request introduce? Check the box that applies.
How did you test it? 🧪
Explain how you tested your changes.
Screenshots (if helpful) 📸
If your changes include something visual, like UI changes, add screenshots here!
Checklist ✅
Make sure you’ve done these things before submitting.
Anything else? 💬
Any extra notes, questions, or concerns for your partner or reviewers?