Added JEP 356: Enhanced Pseudo-Random Number Generators demo referenc…#282
Conversation
…e in Java17 init file
AloisSeckar
left a comment
There was a problem hiding this comment.
Hi @sayiamarora and thank you for your contribution. I have just two little remarks to be addressed. Please, have a look.
src/main/java/org/javademos/java17/jep356/RandomGenerators17.java
Outdated
Show resolved
Hide resolved
src/main/java/org/javademos/java17/jep356/RandomGenerators17.java
Outdated
Show resolved
Hide resolved
|
Hey @AloisSeckar I have committed the changes please review them |
|
Thank you, @sayiamarora The code looks good now, but we recently added new check if the demo collection still runs after the changes and it is failing for your new demo. The runtime exception is: Can you please check your implementation? |
…b.com/sayiamarora/demos-java into feature/jep356-random-generators-demo
|
@AloisSeckar have fixed the issue can you please check!!! |
|
Unfortunately, the pipeline failed again. I am heading for a sport event now and cannot investigate. Will look in the evening. |
AloisSeckar
left a comment
There was a problem hiding this comment.
I hope I have identified the problems with your PR. Please have a look.
src/main/java/org/javademos/java17/jep356/RandomGenerators17.java
Outdated
Show resolved
Hide resolved
…b.com/sayiamarora/demos-java into feature/jep356-random-generators-demo
|
@AloisSeckar used the correct jumpable generator as discussed and correct link I think this time it would work. |
This PR adds the JEP 356 demo reference (Enhanced Pseudo-Random Number Generators) to the Java17 initialization file, aligning with other JEP demo entries.
Closes #221