Skip to content

Conversation

@jakejscott
Copy link
Contributor

@jakejscott jakejscott commented Oct 3, 2025

Having a look into #266

@jakejscott jakejscott reopened this Oct 12, 2025
@bill-poole
Copy link

The detection logic is checking for IOException, HttpIOException or SocketException, but HttpIOException derives from IOException, so it should be possible to just check for IOException and SocketException.

@firenero
Copy link
Contributor

Thanks for the PR @jakejscott. I've made several changes before merging:

  • Propagate IO exceptions instead of wrapping them into DdbException. Since these errors are not caused by DDB itself I think it's fair to throw after retries.
  • Increased retries count to 10 from default 5 just in case.
  • Removed explicit handling of HttpIoException since it implicitly handled by IoException (thanks @bill-poole for spotting it).

@firenero firenero merged commit 7bad9d4 into AllocZero:main Oct 18, 2025
3 checks passed
@jakejscott
Copy link
Contributor Author

Thank you so much! 😊

@jakejscott jakejscott deleted the jakejscott/handle-io-exception branch October 27, 2025 18:33
@firenero firenero linked an issue Nov 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic retry on IOException/SocketException

3 participants