Skip to content

fix: Use correct property of ast.Constant #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davecoates merged 1 commit into from
Dec 2, 2025
Merged

fix: Use correct property of ast.Constant #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/allianceutils/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def _check_explicit_table_names_on_model(model: Type[Model], enforce_lowercase:
first_target = sub_node.targets[0]
if first_target.id == 'db_table': # type:ignore[attr-defined] # isn't present in type defs
if isinstance(sub_node.value, ast.Constant):
found = sub_node.value.s
found = sub_node.value.value
else:
# If it's an expression then we don't know what it's going to evaluate it
# so we're just going to assume it's ok
Expand All @@ -295,7 +295,7 @@ def _check_explicit_table_names_on_model(model: Type[Model], enforce_lowercase:
elif (
first_target.id == 'managed' # type:ignore[attr-defined] # isn't present in type defs
and isinstance(sub_node.value, (ast.Constant))
and sub_node.value.s == False
and sub_node.value.value == False
):
found = True
break
Expand Down