Merged
Conversation
Collaborator
Author
|
I feel like there's an opportunity to consolidate these assembly concepts between EphysAssembly and IcEphysAssembly and FiberAssembly in v3.0 |
Collaborator
Author
|
also, weight in on the name "IcEphysAssembly" - I don't love it but don't have better ideas |
gouwens
reviewed
Feb 19, 2026
dbirman
requested changes
Feb 23, 2026
Member
dbirman
left a comment
dbirman
left a comment
There was a problem hiding this comment.
PatchClampEphysAssembly needs to also be added to the DiscriminatedList for instrument.components
gouwens
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1725