Open
Conversation
old acquisition type was a config, new type is defined in aind_data_schema_models
also add frame_rate_unit and fix slap_acquisition_type -> slap2_acquisition_type
replaces name and target_neuron
…/AllenNeuralDynamics/aind-data-schema into AllenNeuralDynamics-1422-slap2-metadata-requirements
…nto 1422-slap2-metadata-requirements
in anticipation of changes that will be made on the main repo
This reverts commit 238a431.
This reverts commit 5ca000e.
…quirements' into 1422-slap2-metadata-requirements
updated SLAP2 metadata components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the slap2 metadata requirements following discussions with the scientific team.
A few linter/docs changes snuck in that didn't get built properly in other PRs