Skip to content

chore: Husky and lint staged#198

Open
lanesawyer wants to merge 17 commits intomainfrom
lane/lint-fix-and-pre-commit-hooks
Open

chore: Husky and lint staged#198
lanesawyer wants to merge 17 commits intomainfrom
lane/lint-fix-and-pre-commit-hooks

Conversation

@lanesawyer
Copy link
Collaborator

chore: Husky and lint staged

What

Add pre-commit hooks to run the biome fixes that can be done

How

Add hucky
Add lint-staged
Add the configs

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner October 2, 2025 04:40
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a trivial spacing change on this file to see if it would run it on the staged file and it did!! Woooo!

@froyo-np
Copy link
Collaborator

froyo-np commented Oct 2, 2025

So I disable husky pre-hook stuff locally - it does not play nice with git on windows. I'm agreeable to adding this, but I'd really really like to remove some (most?) of these lint rules.

@lanesawyer
Copy link
Collaborator Author

Sorry, could've made the intent here clearer. This is to auto-fix any fixable rules or formatting on commit, not to block commits if they fail a check.

Also I need to verify it's working how I expect! I forgot to test if it allows you to successfully commit with a linting error in the code.

@lanesawyer lanesawyer marked this pull request as draft October 2, 2025 17:12
@lanesawyer
Copy link
Collaborator Author

Shoot, it does prevent commits if there are errors. Will look into this again later!

@lanesawyer lanesawyer marked this pull request as ready for review February 19, 2026 05:36
@lanesawyer
Copy link
Collaborator Author

Finally got back to this and made it so it doesn't block any commits if there are lint errors happening while still doing any formatting or safe linting fixes! This is ready to go 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants