Draft
Conversation
Since we started supporting IP10 in a089d19 (MIES_Include.ipf: Add preliminary support for Igor Pro 10, 2025-04-30) we have reused the IP9 XOP and Help folders. All our own XOPs do work with both versions. But we also have a windows-style shortcut to the IP9 files for the AxonTelegraph. And that we can't use for IP10 as IP9 might not be installed. So let's create per version folders and common folders.
Build 29764 is the first released version.
t-b
force-pushed
the
bugfix/2638-installer
branch
from
82e1e5e to
500e3c5
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows installer toolchain and installer logic to address reported installation/uninstallation issues (Igor Pro 9 vs 10 pathing) and to incorporate the NSIS 3.11 security update.
Changes:
- Vendor/update NSIS tooling (incl. makensis + bundled plugins/UIs/includes/docs) to newer version.
- Fix Igor Pro 10 integration by using IP10-specific XOP folder names and introducing a shared
XOPs-64bitlink target. - Update install docs, CI Igor Pro 10 revision, and Igor Pro 10 download link/build gating.
Reviewed changes
Copilot reviewed 28 out of 133 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/installer/nsis/makensis.exe | Updated vendored NSIS compiler binary. |
| tools/installer/nsis/Plugins/x86-unicode/splash.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/advsplash.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/UserInfo.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/TypeLib.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/LangDLL.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/Dialer.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-unicode/Banner.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/splash.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/nsExec.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/advsplash.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/UserInfo.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/TypeLib.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/LangDLL.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/Dialer.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Plugins/x86-ansi/Banner.dll | Updated vendored NSIS plugin binary. |
| tools/installer/nsis/Include/WinVer.nsh | Updated Windows version mapping (incl. newer Windows 11 releases). |
| tools/installer/nsis/Include/VB6RunTime.nsh | Updated vendored NSIS include copyright header. |
| tools/installer/nsis/Include/MultiUser.nsh | Updated vendored NSIS include copyright header. |
| tools/installer/nsis/Include/LangFile.nsh | Updated vendored NSIS include copyright header. |
| tools/installer/nsis/Examples/makensis.nsi | Updated NSIS example registry metadata. |
| tools/installer/nsis/Examples/Plugin/nsis/pluginapi-x86-ansi.lib | Updated vendored NSIS example library. |
| tools/installer/nsis/Examples/Plugin/nsis/nsis_tchar.h | Updated vendored NSIS example header copyright. |
| tools/installer/nsis/Examples/Plugin/nsis/api.h | Updated vendored NSIS example header copyright. |
| tools/installer/nsis/Examples/NSISMenu.nsi | Updated vendored NSIS example behavior around QUIT_ON_EXECUTE close handling. |
| tools/installer/nsis/Docs/System/System.html | Updated vendored NSIS docs copyright header. |
| tools/installer/nsis/Docs/InstallOptions/Readme.html | Updated vendored NSIS docs copyright header. |
| tools/installer/nsis/Contrib/zip2exe/Base.nsh | Simplified compressor selection to use ${ZIP2EXE_COMPRESSOR}. |
| tools/installer/nsis/Contrib/UIs/sdbarker_tiny.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/modern_smalldesc.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/modern_nodesc.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/modern_headerbmpr.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/modern_headerbmp.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/modern.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/Contrib/UIs/default.exe | Updated vendored NSIS UI binary. |
| tools/installer/nsis/COPYING | Updated vendored NSIS copyright year. |
| tools/installer/nsis/Bin/RegTool-x86.bin | Updated vendored NSIS binary tool. |
| tools/installer/installer.nsi | Fix Igor Pro 10 directory templates, add common XOPs link, update shortcut creation for common XOPs/helpfiles. |
| XOPs-MacOSX-64bit/ZeroMQ-64.xop/Contents/Resources/ZeroMQ-64.rsrc | Added/updated macOS XOP resources. |
| XOPs-MacOSX-64bit/ZeroMQ-64.xop/Contents/Resources/English.lproj/InfoPlist.strings | Added/updated macOS XOP plist strings. |
| XOPs-MacOSX-64bit/ZeroMQ-64.xop/Contents/PkgInfo | Added/updated macOS XOP bundle metadata. |
| XOPs-MacOSX-64bit/ZeroMQ-64.xop/Contents/Info.plist | Added/updated macOS XOP Info.plist. |
| XOPs-MacOSX-64bit/TUF-64.xop/Contents/Resources/TUF-64.rsrc | Added/updated macOS XOP resources. |
| XOPs-MacOSX-64bit/TUF-64.xop/Contents/Resources/English.lproj/InfoPlist.strings | Added/updated macOS XOP plist strings. |
| XOPs-MacOSX-64bit/TUF-64.xop/Contents/PkgInfo | Added/updated macOS XOP bundle metadata. |
| XOPs-MacOSX-64bit/TUF-64.xop/Contents/Info.plist | Added/updated macOS XOP Info.plist. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/_CodeSignature/CodeResources | Added/updated macOS XOP code signature resources. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/Resources/JSON-64.rsrc | Added/updated macOS XOP resources. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/Resources/English.lproj/InfoPlist.strings | Added/updated macOS XOP plist strings. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/PkgInfo | Added/updated macOS XOP bundle metadata. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/Info.plist | Added/updated macOS XOP Info.plist. |
| XOPs-MacOSX-64bit/JSON-64.xop/Contents/CodeResources | Added/updated macOS XOP code signature blob. |
| Packages/doc/installation.rst | Updated install instructions for Igor Pro 10 and new common XOP/helpfile link layout. |
| Packages/MIES_Include.ipf | Updated Igor Pro 10 approved build/link and removed hard “Igor 10 download unsupported” abort. |
| .github/workflows/test-igor-workflow.yml | Bumped CI Igor Pro 10 revision. |
| .github/workflows/test-igor-rebase-exec-workflow.yml | Bumped CI Igor Pro 10 revision. |
| .gitattributes | Adjusted export-ignore for renamed macOS XOP folder and disabled diff for PkgInfo. |
| .editorconfig | Enforced CRLF for .nsi files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t-b
force-pushed
the
bugfix/2638-installer
branch
from
500e3c5 to
283b904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2635
Close #2611