Open
Conversation
This allows Auto TP during automated testing to run longer, as we use the rows to keep track of the current index in TP_AutoBaseline.
By predefining some results we can have a deterministic result and also drop the IUTF_RETRY_FAILED flag. The return values are slightly changed but this does not matter for the test as we only want to test that changing the clamp mode during TP stops Auto TP.
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of Auto Test Pulse tests by addressing timing-related flakiness and resource constraints.
Changes:
- Increased override results buffer size from 64 to 2048 entries to accommodate longer-running tests
- Reduced test duration by stopping test pulse after 2 seconds instead of 10 seconds
- Updated test expectations to reflect proper headstage state after clamp mode change (HS0 remains in IC trying AutoTP, HS1 switches to VC)
- Removed retry pragma since tests are now more stable
- Added early initialization of override results with proper values for both headstages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Packages/tests/HardwareBasic/UTF_AutoTestpulse.ipf | Added override results initialization in preAcq, reduced timing from 10s to 2s, updated test expectations to match new behavior, removed retry pragma |
| Packages/MIES/MIES_TestPulse.ipf | Increased override results buffer size from 64 to 2048 entries to prevent exhaustion during longer test runs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Sounds good. If it passes, we can merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@timjarsky I've polished our hack from Monday.