Update torch version from 2.0.0 to 2.6.0 to be compatible with new CUDA drivers on the A100s#499
Closed
eeangelini wants to merge 4 commits intomainfrom
Closed
Update torch version from 2.0.0 to 2.6.0 to be compatible with new CUDA drivers on the A100s#499eeangelini wants to merge 4 commits intomainfrom
torch version from 2.0.0 to 2.6.0 to be compatible with new CUDA drivers on the A100s#499eeangelini wants to merge 4 commits intomainfrom
Conversation
Open
Contributor
Author
|
UPDATE: As per @smishra3, this is not an issue with the torch version, but instead a problem with how |
Contributor
Author
|
Closing without merging as infra fixed the issue with the un-MIG-ed devices 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #495.
This PR updates the pinned
torchversion inpyproject.tomlto be~=2.6.0(which is the latest version compatible with CUDA 12.4) instead of~=2.0.0(which is compatible with CUDA 11.8 and 11.7).The CUDA drivers on the internal AICS A100s were recently updated from 11.7/11.8 to 12.4, which was causing issues in the
cellsmaprepository: the pinned torch version there is2.0.0in order to have compatibility withcyto-dl. Therefore, in order to update thetorchversion in that repository, we also need to update the torch version here.Before submitting
pytestcommand?pre-commit run -acommand?Notes for reviewers
This is my first time contributing to
cyto-dl, which is also no longer being actively maintained, so I wasn't sure who typically reviews PRs here. Please add anyone that I might have missed!I also am not sure where to start testing to make sure that this change doesn't break anything.