Do not initialize ARCH_CXXFLAGS using ARCH_CFLAGS. #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing ARCH_CXXFLAGS with ARCH_CFLAGS is potentially harmful, as these variables are almost always initialized with recursive expansion appends. If ARCH_CXXFLAGS is assigned in this manner, adding an option like -std=gnu99 to ARCH_CFLAGS will propagate to ARCH_CXXFLAGS even if it's added to ARCH_CFLAGS after initializing ARCH_CXXFLAGS, causing compiler warnings or errors. Instead, either initialize ARCH_CFLAGS and ARCH_CXXFLAGS identically (or near-identically), or prefer setting an arch-specific variable like NDS_CFLAGS for common options which can then be appended to both. See discussion on #571: #571 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing ARCH_CXXFLAGS with ARCH_CFLAGS is potentially harmful, as these variables are almost always initialized with recursive expansion appends. If ARCH_CXXFLAGS is assigned in this manner, adding an option like -std=gnu99 to ARCH_CFLAGS will propagate to ARCH_CXXFLAGS even if it's added to ARCH_CFLAGS after initializing ARCH_CXXFLAGS, causing compiler warnings or errors.
Instead, either initialize ARCH_CFLAGS and ARCH_CXXFLAGS identically (or near-identically), or prefer setting an arch-specific variable like NDS_CFLAGS for common options which can then be appended to both.
See discussion on #571:
#571 (comment)